Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selection styling to Logs table #2485

Merged
merged 3 commits into from
Nov 4, 2020

Conversation

kenzieschmoll
Copy link
Member

Screen Shot 2020-11-03 at 2 14 36 PM

Addresses part of #1982

@devoncarew
Copy link
Member

For the dark theme, the selection background color looks pretty high contrast. Is this a std background selection color for material? Should we be customizing it for our tables? A darker row color may work better.

@kenzieschmoll
Copy link
Member Author

This is the selection color UXD recommended and is used in other parts of DevTools to indicate selection (e.g. timeline, debugger (see #1982 (comment)))

@devoncarew
Copy link
Member

This is the selection color UXD recommended and is used in other parts of DevTools to indicate selection (e.g. timeline, debugger (see #1982 (comment)))

Ah, ok then.

@kenzieschmoll
Copy link
Member Author

This is the selection color UXD recommended and is used in other parts of DevTools to indicate selection (e.g. timeline, debugger (see #1982 (comment)))

Ah, ok then.

However, would not be opposed to revisiting this color in a future polish task - it does seem kind of intense in some places.

@kenzieschmoll kenzieschmoll merged commit b7bff74 into flutter:master Nov 4, 2020
@kenzieschmoll kenzieschmoll deleted the logging branch November 4, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants