Add search to the Network profiler #2333
Conversation
kenzieschmoll
commented
Sep 11, 2020
| @@ -161,6 +165,18 @@ class _NetworkScreenBodyState extends State<NetworkScreenBody> | |||
| _networkController.clear(); | |||
| }, | |||
| ), | |||
| const Expanded(child: SizedBox()), | |||
There was a problem hiding this comment.
can you change the properties on the row instead of adding this degenerate expanded?
There was a problem hiding this comment.
There are six other items in the row, so changing the row alignment would affect all of those items as well. I could wrap all the other items in their own row, and then use spaceBetween but this felt simpler and cleaner
| final isPreviousActiveSearchMatch = activeSearchMatch == widget.node; | ||
| final isNewActiveSearchMatch = | ||
| widget.activeSearchMatchNotifier.value == widget.node; | ||
| activeSearchMatch = widget.activeSearchMatchNotifier.value; |
There was a problem hiding this comment.
move this duplicated code into a helper.
There was a problem hiding this comment.
it's not actually duplicated - its searchMatch vs activeSearchMatch, which are two different entities
| @@ -740,6 +739,10 @@ class _TableState<T> extends State<_Table<T>> with AutoDisposeMixin { | |||
| } | |||
| }); | |||
| }); | |||
|
|
|||
| if (widget.activeSearchMatchNotifier != null) { | |||
There was a problem hiding this comment.
redundant check for the notifier being not null.
There was a problem hiding this comment.
removed now that the check is inside _initSearchListener
| @@ -740,6 +739,10 @@ class _TableState<T> extends State<_Table<T>> with AutoDisposeMixin { | |||
| } | |||
| }); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
why isn't the selection notifier listener also tracked in the helper called from initState and didUpdateWidget?
There was a problem hiding this comment.
I didn't modify anything about the selection listener because it's not in the scope of this PR - will add a note to address
|
|
|
Fixes #2316 |