Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner message warnings and errors #1764

Merged
merged 16 commits into from
Mar 27, 2020
+837 −76
Merged

Add banner message warnings and errors #1764

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
91ff009
Add banner message warnings and errors.
kenzieschmoll Mar 24, 2020
76abb9d
Add tests.
kenzieschmoll Mar 25, 2020
6f905fd
Add memory message and more tests.
kenzieschmoll Mar 25, 2020
7c8a06e
Add const
kenzieschmoll Mar 25, 2020
ad8d658
Address some review comments
kenzieschmoll Mar 25, 2020
6b742cc
Review comments - switch to inherited widget pattern
kenzieschmoll Mar 26, 2020
657ab25
add todo
kenzieschmoll Mar 26, 2020
1fe08fa
Fix tests.
kenzieschmoll Mar 26, 2020
c8741da
Merge branch 'master' into profileModeWarning
kenzieschmoll Mar 26, 2020
b488f7b
fix flame chart test
kenzieschmoll Mar 26, 2020
56a4ca4
Merge branch 'master' of github.com:flutter/devtools into profileMode…
kenzieschmoll Mar 26, 2020
08c742f
Merge branch 'profileModeWarning' of github.com:kenzieschmoll/devtool…
kenzieschmoll Mar 26, 2020
86cf75a
address lints
kenzieschmoll Mar 26, 2020
e528485
Review comments.
kenzieschmoll Mar 27, 2020
f1800e3
fix test
kenzieschmoll Mar 27, 2020
6621925
review comments and fix test
kenzieschmoll Mar 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/devtools_app/lib/src/connected_app.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ class ConnectedApp {

bool get isFlutterWebAppNow => isFlutterAppNow && isDartWebAppNow;

bool get isDebugFlutterAppNow => isFlutterAppNow && !isProfileBuildNow;

bool get isRunningOnDartVM => serviceManager.vm.name != 'ChromeDebugProxy';

Future<bool> get isDartCliApp async =>
Expand Down
Loading