Disable DevTools pages based on the connected app type. #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
reviewed
Mar 20, 2020
| @@ -392,3 +392,57 @@ class OutlinedBorder extends StatelessWidget { | |||
| /// | |||
| /// Makes for nice-looking rectangles. | |||
| final goldenRatio = 1 + sqrt(5) / 2; | |||
|
|
|||
| class DisabledForProfileModeMessage extends StatelessWidget { | |||
There was a problem hiding this comment.
👍 I like the individual, specific messages telling why the page is disabled.
packages/devtools_app/lib/src/inspector/flutter/inspector_screen.dart
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/devtools_app/lib/src/timeline/flutter/timeline_screen.dart
devoncarew
approved these changes
Mar 20, 2020
| bool get isRunningOnDartVM => serviceManager.vm.name != 'ChromeDebugProxy'; | ||
|
|
||
| Future<bool> get isDartCliApp async => | ||
| FutureOr<bool> get isDartCliApp async => |
There was a problem hiding this comment.
I think Future<bool> is correct here.
There was a problem hiding this comment.
since isFlutterApp returns a FutureOr, wouldn't it be FutureOr?
There was a problem hiding this comment.
I think they can both be changed to Future?
It's not a critical change.
| style: Theme.of(context).textTheme.headline4, | ||
| ), | ||
| ), | ||
| child: CenteredMessage('Sorry, $uri was not found.'), |
There was a problem hiding this comment.
We should definitely include a version of the chrome 404 dinosaur game here: https://lmgtfy.com/?q=chrome+404+dinosaur+game.
jacob314
reviewed
Mar 23, 2020
jacob314
reviewed
Mar 23, 2020
jacob314
reviewed
Mar 23, 2020
jacob314
reviewed
Mar 23, 2020
| NetworkScreen screen; | ||
| FakeServiceManager fakeServiceManager; | ||
|
|
||
| group('NetworkScreen', () { |
jacob314
reviewed
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the page is not supported for the connected app, we show a full screen message explaining why the page is disabled.
Fixes #1669