Add sorting functionality to flutter tables. #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Mar 13, 2020
jacob314
reviewed
Mar 13, 2020
jacob314
reviewed
Mar 13, 2020
jacob314
reviewed
Mar 13, 2020
jacob314
reviewed
Mar 13, 2020
jacob314
reviewed
Mar 13, 2020
jacob314
reviewed
Mar 13, 2020
| @@ -19,32 +19,30 @@ class CpuProfilerController { | |||
| static CpuProfileData baseStateCpuProfileData = CpuProfileData.empty(); | |||
|
|
|||
| /// Notifies that new cpu profile data is available. | |||
| ValueListenable get dataNotifier => _dataNotifier; | |||
| ValueListenable get data => _dataNotifier; | |||
There was a problem hiding this comment.
this refactor looks only half done. The privates still have _notifier in the name.
Also looks unrelated. Maybe move to a separate CL?
There was a problem hiding this comment.
This is what I did in timeline_controller.dart. I was actually in favor of leaving the ValueNotifier vars as *_notifier since it is easy to tell which value is read only and which value is read-write. Either way, I'll revert back and do as a follow up CL.
jacob314
reviewed
Mar 13, 2020
jacob314
reviewed
Mar 13, 2020
jacob314
reviewed
Mar 14, 2020
# Conflicts: # packages/devtools_app/lib/src/flutter/common_widgets.dart # packages/devtools_app/lib/src/ui/flutter/service_extension_widgets.dart
jacob314
reviewed
Mar 16, 2020
| @@ -39,6 +39,8 @@ ThemeData _lightTheme() { | |||
| } | |||
|
|
|||
| const buttonMinWidth = 36.0; | |||
| const defaultIconSize = 16.0; | |||
There was a problem hiding this comment.
fyi @devoncarew these constants might be relevant for some of your CLs as well.
# Conflicts: # packages/devtools_app/lib/src/flutter/table.dart # packages/devtools_app/lib/src/logging/flutter/logging_screen.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of https://github.com//issues/1657