Port CPU bottom up table to Flutter. #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
| } | ||
|
|
||
| void _performOnDataRoots( |
There was a problem hiding this comment.
This is a nice approach to this problem.
| @@ -161,6 +161,20 @@ void main() { | |||
| expect(find.byKey(const Key('empty')), findsOneWidget); | |||
| }); | |||
|
|
|||
| testWidgets('displays with multiple data roots', | |||
There was a problem hiding this comment.
Please also add a test for interactions on the roots: ensure that a few of the roots are properly expandable without breaking the state of the rest of the tree.
There was a problem hiding this comment.
Also, include tests for the cases where the roots of the tree are changed. We don't want to get a red screen of death when we request new data and we get a broken tree because there were fewer roots being used by the same tree representation.
This was referenced Feb 24, 2020
Closed
# Conflicts: # packages/devtools_app/lib/src/profiler/flutter/cpu_profiler.dart # packages/devtools_app/test/flutter/cpu_profiler_test.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change applies to both the Timeline page (#1289) and the Performance page (#1287)