Add zoomable timeline grid and timestamps to flame chart. #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kenzieschmoll
commented
Feb 12, 2020
|
Partially addresses #1289. |
jacob314
reviewed
Feb 12, 2020
jacob314
reviewed
Feb 12, 2020
| )..layout(maxWidth: intervalWidth); | ||
|
|
||
| // TODO(kenz): figure out a way for the timestamps to scroll out of view | ||
| // smoothly instead of dropping off. |
There was a problem hiding this comment.
if you use a horizontal ListView for the timestamps and use Text widgets you would get that for free. It may be a bit more performant as well as it might do a better job of caching text rendering
There was a problem hiding this comment.
added a this to the TODO since it may take a bit of refactoring where we calculate intervals and such. It also may be kind of tricky because we would have to inject new widgets into the list when we split each interval into two new intervals (when log2(zoom) increases).
jacob314
reviewed
Feb 12, 2020
packages/devtools_app/lib/src/timeline/flutter/timeline_flame_chart.dart
Outdated
Show resolved
Hide resolved
jacob314
reviewed
Feb 12, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.