Flame chart zoom and navigation with WASD keys #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| previousZoom = currentZoom; | ||
| linkedHorizontalScrollControllerGroup | ||
| .jumpTo(newScrollOffset.clamp(minScrollOffset, maxScrollOffset)); |
There was a problem hiding this comment.
This entire section is very well explained. Thanks!
jacob314
reviewed
Feb 10, 2020
| // Only handle down events so logic is not duplicated on key up. | ||
| if (event is RawKeyDownEvent) { | ||
| // Handle zooming / navigation from W-A-S-D keys. | ||
| final keyLabel = event.data.keyLabel; |
There was a problem hiding this comment.
nit: why are we using wsad instead of the arrow keys? is that for compatibility with the observatory?
There was a problem hiding this comment.
WASD will be familiar for users with experience using other trace viewers (e.g. chrome://tracing, Observatory, etc.). Wdyt about allowing both WASD and the arrow keys to zoom / pan?
jacob314
reviewed
Feb 10, 2020
packages/devtools_app/lib/src/timeline/flutter/timeline_flame_chart.dart
Show resolved
Hide resolved
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement flame chart zoom with WASD keys.
Fixes #683
P.S. Excuse the ugly commit history. Rebasing was a nightmare.