Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload CocoaPods 1.16.0 in Ruby cipd package #3992

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Upload CocoaPods 1.16.0 in Ruby cipd package #3992

merged 2 commits into from
Oct 29, 2024

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Oct 28, 2024 •
edited
Loading

Update CocoaPods to 1.16.0 to pick up Xcode 16 support.

See https://github.com/flutter/cocoon/blob/7683f41ec82e0cc2be65233d625749ed61c0f6c9/cipd_packages/ruby/README.md#installing-cocoapods.

Part of flutter/flutter#157737

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Oct 28, 2024
christopherfujino
christopherfujino approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Oct 28, 2024 •
edited
Loading

I was confused, 1.26 edit: 1.16.0 has been tagged but not yet released. This will have to wait for gem install cocoapods -v 1.26.0 to succeed.

@jmagman jmagman marked this pull request as draft October 28, 2024 18:59
@christopherfujino
Copy link
Member

I was confused, 1.26 has been tagged but not yet released. This will have to wait for gem install cocoapods -v 1.26.0 to succeed.

acknowledged.

@jmagman jmagman changed the title Upload CocoaPods 1.26 in Ruby cipd package Upload CocoaPods 1.16.0 in Ruby cipd package Oct 29, 2024
@jmagman jmagman mentioned this pull request Oct 29, 2024
Open
6 tasks
@jmagman
Copy link
Member Author

jmagman commented Oct 29, 2024 

Error: Could not rename m4 keg! Check/fix its permissions:
  sudo chown -R swarming /opt/homebrew/Cellar/m4/1.4.19

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8732774199110174961/+/u/build_package/stdout

@jmagman jmagman marked this pull request as ready for review October 29, 2024 16:29
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App. label Oct 29, 2024
@auto-submit auto-submit bot merged commit e7514b1 into flutter:main Oct 29, 2024
5 checks passed
@jmagman jmagman deleted the cocoapods-1_26 branch October 29, 2024 16:35
@jmagman jmagman mentioned this pull request Oct 29, 2024
Open
@jmagman
Copy link
Member Author

jmagman commented Oct 29, 2024

It passed on rerun, filed flutter/flutter#157803.

@jmagman jmagman mentioned this pull request Nov 5, 2024
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Nov 5, 2024
@jmagman
Upload CocoaPods 1.16.2 in Ruby cipd package (#4010)
c68306f 
Follow up to #3992.
Pick up bug fixes from https://github.com/CocoaPods/CocoaPods/releases/tag/1.16.1 and https://github.com/CocoaPods/CocoaPods/releases/tag/1.16.2.

Particularly the revert of the issues explained in CocoaPods/Xcodeproj#987 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees

@jmagman jmagman

Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmagman @christopherfujino