Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pubspec.lock to .gitignore #55

Merged
merged 1 commit into from
May 23, 2021
Merged

Add pubspec.lock to .gitignore #55

merged 1 commit into from
May 23, 2021

Conversation

albertus-stripe
Copy link
Contributor

We should not be checking in pubspec.lock changes to the repository.

I checked several other Flutter's open-source plugins and none of them are checking in the pubspec.lock right now:

  1. Flutter Plugins https://github.com/flutter/plugins/tree/master/packages
  2. FlutterFire https://github.com/flutter/plugins/tree/master/packages

@jamesblasco jamesblasco merged commit 6095127 into main May 23, 2021
@albertus-stripe albertus-stripe mentioned this pull request May 24, 2021
Closed
@jamesblasco jamesblasco deleted the ignore-pubspec-lock branch May 24, 2021 06:46
@Nitingadhiya Nitingadhiya mentioned this pull request Apr 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesblasco jamesblasco jamesblasco approved these changes

@jonasbark jonasbark Awaiting requested review from jonasbark

@remonh87 remonh87 Awaiting requested review from remonh87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertus-stripe @jamesblasco