Fix Options::validate() to accept update option alone

Options::validate() threw an exception, when only update option was passed.
fluks · Dec 4, 2016 · 4c91077 · 4c91077
1 parent d170a5c
commit 4c91077
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/options.cpp b/src/options.cpp
@@ -153,7 +153,7 @@ Pdfsearch::Options::getopt() {
 
 void
 Pdfsearch::Options::validate() const {
-    if (!index && query.empty() && !vacuum) {
+    if (!index && query.empty() && !vacuum && !update) {
         throw std::invalid_argument("either index, query, update or vacuum "
             "option must be selected");
     }

diff --git a/tests/00-options.cpp b/tests/00-options.cpp
@@ -279,3 +279,11 @@ TEST_CASE("config file not found", "[options]") {
 
     REQUIRE_THROWS_AS(o.getopt(), std::ios_base::failure);
 }
+
+TEST_CASE("validate - update option alone ok", "[options]") {
+    const char* argv[] = { "", "-u" };
+    Pdfsearch::Options o(2, const_cast<char**>(argv));
+    o.getopt();
+
+    REQUIRE_NOTHROW(o.validate());
+}