Merge pull request #1097 from duhrer/FLUID-6755

FLUID-6755: Update to last released version of fluid-lint-all.

README.md

@@ -139,7 +139,7 @@ below.
 
 ##### -i, --include
 
-__value__: "module(s)" (String)
+**value**: "module(s)" (String)
 _only available to custom builds_
 
 The `--include` option takes a comma-separated string of the [Modules](#modules) to be included in a custom package.
@@ -155,7 +155,7 @@ npm run build:pkg:custom -- -i "fluid-inline-edit, fluid-ui-options"
 
 ##### -e, --exclude
 
-__value__: "module(s)" (String)
+**value**: "module(s)" (String)
 _only available to custom builds_
 
 The `--exclude` option takes a comma-separated string of the [Modules](#modules) to be excluded from a custom package.
@@ -170,7 +170,7 @@ npm run build:pkg:custom -- -e jquery
 
 ##### -n, --name
 
-__value__: "custom suffix" (String)
+**value**: "custom suffix" (String)
 _only available to custom packages which have specified an include and/or exclude option_
 
 By default, custom packages are given a name in the form _infusion-custom-{version}.zip_ and the concatenated JavaScript

package.json

@@ -98,10 +98,10 @@
         "browserslist-config-fluid": "0.1.0",
         "cpy-cli": "3.1.1",
         "dayjs": "1.10.7",
-        "eslint-config-fluid": "2.0.0",
-        "eslint-plugin-jsdoc": "37.0.3",
+        "eslint-config-fluid": "2.1.1",
+        "eslint-plugin-jsdoc": "39.6.2",
         "fast-glob": "3.2.11",
-        "fluid-lint-all": "1.1.5",
+        "fluid-lint-all": "1.2.3",
         "fluid-testem": "2.1.15",
         "hypher": "0.2.5",
         "jquery": "3.6.0",

src/framework/core/js/Fluid.js

@@ -1273,13 +1273,15 @@ fluid.bind = function (obj, fnName, args) {
 
 // Stub for function in FluidIoC.js
 fluid.proxyComponentArgs = fluid.identity;
+/* eslint-disable jsdoc/require-returns-check */
 /**
  * Allows for the calling of a function from an EL expression "functionPath", with the arguments "args", scoped to an framework version "environment".
  * @param {Object} functionPath - An EL expression
  * @param {Object} args - An array of arguments to be applied to the function, specified in functionPath
  * @param {Object} [environment] - (optional) The object to scope the functionPath to  (typically the framework root for version control)
  * @return {Any} - The return value from the invoked function.
  */
+/* eslint-enable jsdoc/require-returns-check */
 fluid.invokeGlobalFunction = function (functionPath, args, environment) {
     var func = fluid.getGlobalValue(functionPath, environment);
     if (!func) {

src/framework/core/js/FluidIoC.js

@@ -404,6 +404,7 @@ fluid.matchIoCSelector = function (selector, thatStack, contextHashes, memberNam
             return false;
         }
     }
+    return false;
 };
 
 // supported, PUBLIC API function
@@ -2251,6 +2252,7 @@ fluid.applyWorkflowPhase = function (transRec, sequencer) {
             }
         }
     }
+    return false;
 };
 
 /** Operate one phase of a tree transaction, consisting of a list of component destructions and a list of

src/framework/core/js/FluidView.js

@@ -574,7 +574,7 @@ fluid.materialiserRegistry["fluid.viewComponent"] = {
  * radio button/checkbox sets, potentially, given a node corresponding to just one element.
  * @param {jQuery} nodeIn - The node whose value is to be read or written
  * @param {Any} newValue - If `undefined`, the value will be read, otherwise, the supplied value will be applied to the node
- * @return {Any} The queried value, if `newValue` was undefined
+ * @return {Any|undefined} The queried value, if `newValue` was undefined, otherwise `undefined`.
  */
 fluid.value = function (nodeIn, newValue) {
     var node = fluid.unwrap(nodeIn);

src/framework/core/js/MessageResolver.js

@@ -120,7 +120,7 @@ fluid.messageLocator = function (messageBase, resolveFunc) {
  * function.
  *
  * @param {Object} messageSource - See above.
- * @return {Function|String} - A resolve function or a `String` representing the final resolved output.
+ * @return {Function|String|undefined} - A resolve function or a `String` representing the final resolved output.
  */
 fluid.resolveMessageSource = function (messageSource) {
     if (messageSource.type === "data") {

src/framework/preferences/js/PrimaryBuilder.js

@@ -124,6 +124,7 @@ fluid.prefs.primaryBuilder.defaultSchemaIndexer = function (defaults) {
     if (defaults.schema) {
         return fluid.keys(defaults.schema.properties);
     }
+    return [];
 };
 
 /*******************************************************************************

src/framework/preferences/js/Store.js

@@ -129,7 +129,7 @@ fluid.defaults("fluid.prefs.cookieStore.writable", {
  * Retrieve and return the value of the cookie
  *
  * @param {CookieOpts} options - the cookie attributes; used to get the cookie name.
- * @return {String} - the serialized cookie
+ * @return {String|undefined} - the serialized cookie, or `undefined` if no cookie is found.
  */
 fluid.prefs.cookieStore.getCookie = function (options) {
     var cookieName = fluid.get(options, ["directModel", "cookieName"]) || options.name;