Set the node-puhlish-method as symlink mode for vineyard runtime. #3728
Conversation
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
|
Hi @dashanji. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3728 +/- ##
=======================================
Coverage 64.40% 64.40%
=======================================
Files 474 474
Lines 28336 28339 +3
=======================================
+ Hits 18249 18252 +3
Misses 7913 7913
Partials 2174 2174 ☔ View full report in Codecov by Sentry. |
pkg/ddc/vineyard/runtime_info.go
Outdated
| @@ -26,6 +26,11 @@ func (e *VineyardEngine) getRuntimeInfo() (base.RuntimeInfoInterface, error) { | |||
| return e.runtimeInfo, err | |||
| } | |||
|
|
|||
| // Add the symlink method to the vineyard runtime metadata | |||
| runtime.ObjectMeta.Annotations = map[string]string{ | |||
There was a problem hiding this comment.
If there are other annotations in ObjectMeta, will they be overwrited?
There was a problem hiding this comment.
Thanks for pointing it out. I have changed the logic to avoid overwriting and added the unit test.
637ab26 to
3bc01c7
Compare
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
3bc01c7 to
3d581b4
Compare
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
A followup of #3713