Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add common labels to resources that managed by fluid #3720

Conversation

TrafalgarZZZ
Copy link
Member

@TrafalgarZZZ TrafalgarZZZ commented Feb 6, 2024

Ⅰ. Describe what this PR does

  • Add a "library" helm chart which consists of common template functions for all runtimes. (For now, it has only one tpl function to add common labels)
  • Add common labels like fluid.io/managed-by=fluid app.kubernetes.io/name, app.kubernetes.io/instance, app.kubernetes.io/managed-by=Helm to runtime charts.
  • [TODO] Add common labels to Configmaps created by Fluid Controllers and Fluid Webhook.
  • [TODO] Add common labels to PVC & PV created by Fluid Controllers

NOTES:

  • Common labels follow Kubernetes recommended labels guide and helm's standard labels guide.
  • According to the helm's standard labels guide, app.kubernetes.io/managed-by should always be set to {{ .Release.Service }}. So we add another label fluid.io/managed-by to indicate the resource is managed by fluid.
  • Labels like release: {{ .Release.Name }} and heritage: {{ .Release.Service }} will be DEPRECATED some time in future version.

Ⅱ. Does this pull request fix one issue?

fixes #3719

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

fluid-e2e-bot bot commented Feb 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb09e27) 64.40% compared to head (e41f096) 64.40%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3720   +/-   ##
=======================================
  Coverage   64.40%   64.40%           
=======================================
  Files         474      474           
  Lines       28336    28336           
=======================================
  Hits        18249    18249           
  Misses       7913     7913           
  Partials     2174     2174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TrafalgarZZZ
Copy link
Member Author

/test fluid-e2e

@TrafalgarZZZ
Copy link
Member Author

/retest

@TrafalgarZZZ
Copy link
Member Author

/test fluid-e2e

@TrafalgarZZZ TrafalgarZZZ marked this pull request as ready for review February 8, 2024 03:14
@cheyang
Copy link
Collaborator

cheyang commented Feb 8, 2024

@TrafalgarZZZ please fix the conflict. thanks.

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the conflict. Thanks.

@fluid-e2e-bot fluid-e2e-bot bot removed the approved label Feb 11, 2024
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ TrafalgarZZZ force-pushed the enhancement/common_labels_for_fluid branch from 93a270b to e41f096 Compare February 21, 2024 02:47
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
12.6% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cheyang
Copy link
Collaborator

cheyang commented Feb 21, 2024

/test fluid-e2e

@TrafalgarZZZ
Copy link
Member Author

/retest

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Feb 21, 2024
Copy link

fluid-e2e-bot bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit ad3039a into fluid-cloudnative:master Feb 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Fluid should add "managed-by" label to all the created resources
2 participants