refactor: safe exec commands #3699
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3699 +/- ##
=======================================
Coverage 64.46% 64.47%
=======================================
Files 474 473 -1
Lines 28275 28245 -30
=======================================
- Hits 18228 18211 -17
+ Misses 7889 7879 -10
+ Partials 2158 2155 -3 ☔ View full report in Codecov by Sentry. |
|
/test fluid-e2e |
1 similar comment
|
/test fluid-e2e |
| var illegalSequences = []string{"&", ";", "$", "'", "`", "(", ")", "||", ">>"} | ||
|
|
||
| var allowedEnvs = []string{ | ||
| "${METAURL}", // JuiceFS community's metaurl |
There was a problem hiding this comment.
How about using allowedExpressions to replace allowedEnvs?
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
6a887da to
4e2108f
Compare
|
|
/test fluid-e2e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
SimpleCommandtoCommandPipeCommandtoShellCommandwhich checks all(ba)sh -c-like commandsⅡ. Does this pull request fix one issue?
NONE
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews