-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimize makefile targets and speed up docker build #3246
optimize: optimize makefile targets and speed up docker build #3246
Conversation
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
/test fluid-e2e |
Codecov Report
@@ Coverage Diff @@
## master #3246 +/- ##
=======================================
Coverage 65.53% 65.53%
=======================================
Files 397 397
Lines 23112 23112
=======================================
Hits 15147 15147
Misses 6183 6183
Partials 1782 1782 |
/retest |
2 similar comments
/retest |
/retest |
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
/retest |
1 similar comment
/retest |
/test fluid-e2e |
1 similar comment
/test fluid-e2e |
It's better to set gen-openapi check in github action just like "CRD validation check" |
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Moved from |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Optimize makefile targets and speed up docker build. The PR removes redundant
generate fmt vet gen-openapi
actions away from the original Makefile targets and do once before targets likemake build
,make docker-push-all
.Targets for building one single component will no longer check these actions
generate fmt vet gen-openapi
.Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews