Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Set Dataset.Spec.Mounts as a required property #3240

Conversation

TrafalgarZZZ
Copy link
Member

Ⅰ. Describe what this PR does

Currently, Dataset.Spec.Mounts is an optional property, allowing users to create a Dataset without mounts. This PR changes it as a required property to make CRD validation works.

For example, the following will be illegal after this PR:

apiVersion: data.fluid.io/v1alpha1
kind: Dataset
metadata:
  name: hbase
spec:

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cheyang
Copy link
Collaborator

cheyang commented May 19, 2023

/hold

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@fluid-e2e-bot fluid-e2e-bot bot removed the lgtm label May 19, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.4% 8.4% Duplication

@cheyang
Copy link
Collaborator

cheyang commented May 19, 2023

/test fluid-e2e

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #3240 (b44fa4d) into master (8322397) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head b44fa4d differs from pull request most recent head 6df70fc. Consider uploading reports for the commit 6df70fc to get more accurate results

@@            Coverage Diff             @@
##           master    #3240      +/-   ##
==========================================
- Coverage   65.54%   65.53%   -0.01%     
==========================================
  Files         397      397              
  Lines       23111    23111              
==========================================
- Hits        15148    15146       -2     
- Misses       6182     6183       +1     
- Partials     1781     1782       +1     
Impacted Files Coverage Δ
api/v1alpha1/dataset_types.go 8.69% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label May 19, 2023
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented May 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 3ef8adc into fluid-cloudnative:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants