-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: Set Dataset.Spec.Mounts as a required property #3240
bugfix: Set Dataset.Spec.Mounts as a required property #3240
Conversation
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold |
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Kudos, SonarCloud Quality Gate passed!
|
/test fluid-e2e |
Codecov Report
@@ Coverage Diff @@
## master #3240 +/- ##
==========================================
- Coverage 65.54% 65.53% -0.01%
==========================================
Files 397 397
Lines 23111 23111
==========================================
- Hits 15148 15146 -2
- Misses 6182 6183 +1
- Partials 1781 1782 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Currently,
Dataset.Spec.Mounts
is an optional property, allowing users to create a Dataset withoutmounts
. This PR changes it as a required property to make CRD validation works.For example, the following will be illegal after this PR:
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews