Add EACRuntime Controller cmd #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2359 +/- ##
========================================
Coverage 50.49% 50.50%
========================================
Files 340 344 +4
Lines 25532 25674 +142
========================================
+ Hits 12892 12966 +74
- Misses 11175 11240 +65
- Partials 1465 1468 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cheyang
reviewed
Nov 25, 2022
| # Debug | ||
| RUN go install github.com/go-delve/delve/cmd/dlv@v1.8.2 | ||
|
|
||
| FROM alpine:3.10 |
There was a problem hiding this comment.
I suggest using registry.cn-hangzhou.aliyuncs.com/acs/alpine:3.16-base.
cheyang
reviewed
Nov 25, 2022
| } | ||
| setupLog.Info("port range parsed", "port range", pr.String()) | ||
|
|
||
| portallocator.SetupRuntimePortAllocator(mgr.GetClient(), pr, eac.GetReservedPorts) |
There was a problem hiding this comment.
you can try SetupRuntimePortAllocatorWithType and use Random.
cheyang
approved these changes
Nov 26, 2022
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Feb 14, 2023
* eac cmd Signed-off-by: mayingchun <mayingchun321@gmail.com> * ut Signed-off-by: mayingchun <mayingchun321@gmail.com> * fix Signed-off-by: mayingchun <mayingchun321@gmail.com> * more ut Signed-off-by: mayingchun <mayingchun321@gmail.com> Signed-off-by: mayingchun <mayingchun321@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Add EACRuntime Controller cmd.
Ⅱ. Does this pull request fix one issue?
fixes #2352
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
unit test
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews