add thinRuntime #2098
Merged
add thinRuntime #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2098 +/- ##
==========================================
- Coverage 52.72% 51.44% -1.28%
==========================================
Files 298 325 +27
Lines 21726 23867 +2141
==========================================
+ Hits 11454 12279 +825
- Misses 9048 10247 +1199
- Partials 1224 1341 +117
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cheyang
reviewed
Sep 1, 2022
|
|
||
| result.Done = true | ||
|
|
||
| datasetUFSTotalBytes, err := t.TotalStorageBytes() |
There was a problem hiding this comment.
What if no fuse running pod exists, in which case UfsTotal will be calculated wrong(e.g. 0.00B)
| Worker ThinCompTemplateSpec `json:"worker,omitempty"` | ||
|
|
||
| // The component spec of thinRuntime | ||
| Fuse ThinFuseSpec `json:"fuse,omitempty"` |
There was a problem hiding this comment.
Some storage, for example NFS, does not use Fuse. Maybe it's better to use something like DataClient or PosixClient instead of Fuse?
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
9ccc585 to
abdbac6
Compare
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
|
@zwwhdls Thanks very much for your great contribution to Fluid community. |
cheyang
approved these changes
Sep 16, 2022
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
add thinRuntime in order to make general storage easier to integrate fluid
design doc: https://docs.google.com/document/d/1tRNr623891uTS36n071h-iTSIw60c10Jvr27ITMBO5U/edit#heading=h.cnrvl4py38io
Ⅱ. Does this pull request fix one issue?
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews