Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fake logging #1692

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Mar 30, 2022

Signed-off-by: cheyang cheyang@163.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #1693

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

cheyang added 3 commits March 30, 2022 15:18
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
@cheyang cheyang requested a review from zwwhdls March 30, 2022 07:33
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #1692 (14abb6b) into master (e018db9) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 14abb6b differs from pull request most recent head 0ba12b7. Consider uploading reports for the commit 0ba12b7 to get more accurate results

@@            Coverage Diff             @@
##           master    #1692      +/-   ##
==========================================
+ Coverage   70.76%   70.81%   +0.04%     
==========================================
  Files         238      238              
  Lines       13129    13129              
==========================================
+ Hits         9291     9297       +6     
+ Misses       2843     2840       -3     
+ Partials      995      992       -3     
Impacted Files Coverage Δ
pkg/ddc/goosefs/metadata.go 64.28% <0.00%> (+3.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e018db9...0ba12b7. Read the comment docs.

@cheyang cheyang merged commit bf3b453 into fluid-cloudnative:master Mar 30, 2022
@cheyang cheyang deleted the refactor_fake_logging branch March 31, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Refactor fake logging
2 participants