Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize makefile #1343

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Jan 5, 2022

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #1344

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
@cheyang cheyang requested a review from zwwhdls January 5, 2022 14:07
Signed-off-by: cheyang <cheyang@163.com>
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #1343 (3f1dd5a) into master (ab54f1e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1343   +/-   ##
=======================================
  Coverage   70.48%   70.48%           
=======================================
  Files         221      221           
  Lines       12122    12122           
=======================================
  Hits         8544     8544           
  Misses       2659     2659           
  Partials      919      919           
Impacted Files Coverage Δ
pkg/utils/kubeclient/exec.go 25.97% <ø> (ø)
pkg/webhook/certificate_builder.go 79.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab54f1e...3f1dd5a. Read the comment docs.

@cheyang cheyang merged commit 916c9fb into fluid-cloudnative:master Jan 6, 2022
@cheyang cheyang deleted the optimize_makefile branch April 18, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Break long dependencies in Makefile for more readable
2 participants