-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade controller runtime 0.8.3 and K8s 1.20 #1207
Upgrade controller runtime 0.8.3 and K8s 1.20 #1207
Conversation
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
73456bd
to
c0f3c89
Compare
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Codecov Report
@@ Coverage Diff @@
## master #1207 +/- ##
==========================================
+ Coverage 66.30% 66.69% +0.39%
==========================================
Files 207 207
Lines 11152 11156 +4
==========================================
+ Hits 7394 7441 +47
+ Misses 2964 2916 -48
- Partials 794 799 +5
Continue to review full report at Codecov.
|
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
@@ -1,143 +1,146 @@ | |||
|
|||
--- | |||
apiVersion: apiextensions.k8s.io/v1beta1 | |||
apiVersion: apiextensions.k8s.io/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apiextensions.k8s.io/v1
is supported since v1.16, what about k8s v1.14/v1.15 ?
k8s.io/klog v1.0.0 | ||
k8s.io/klog/v2 v2.9.0 // indirect | ||
k8s.io/kube-openapi v0.0.0-20201113171705-d219536bb9fd | ||
k8s.io/kubernetes v1.20.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not use Kubernetes pkg directly ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using bash k8s-mod.sh v1.20.10
to upgrade K8s version. This script is from K8s and using the exact same version in K8s repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's fixed. See the latest commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome !
Because if Fluid uses the kubernetes package directly, a project that references Fluid must also maintain replace in go.mod,
This is not an official recommended approach, kubernetes/kubernetes#90358 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was using same useful library, and I am afraid it's Inevitable.
I was using the solution in kubernetes/kubernetes#79384. It works as a charm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I got it
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Can you describe the impact of the version update and why it was updated in issue #1208 ? |
The purpose is to match K8s 1.22. As you know a lot of APIs are removed since 1.22, including CSI, CRD, webhook. We have to upgrade the K8s version, and during the upgrade we found the controller-runtime has to be upgraded also. |
Signed-off-by: cheyang <cheyang@163.com>
For User, if your kubernetes version under 1.16.0, can only use fluid berfore this pr, right? |
It can support the K8s version whose version >= 1.16. Actually, K8s 1.14's EOL date is 2019-12-11, about 2 years ago. But I plan to provide limited support in helm chart, for example in the version 1.14, we can install CRD with v1beta1, while webhook is not supported. https://kubernetes.io/releases/patch-releases/#non-active-branch-history |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks. |
LGTM |
Ⅰ. Describe what this PR does
runtime.Object
toclient.Object
Reconcile
is changed fromreq ctrl.Request
toctx context.Context, req ctrl.Request
apiextensions.k8s.io/vebeta1
toapiextensions.k8s.io/v1
storage.k8s.io/v1beta1
tostorage.k8s.io/v1
admissionregistration.k8s.io/v1beta1
toadmissionregistration.k8s.io/v1
Ⅱ. Does this pull request fix one issue?
fixes #1208
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews