Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue for jindo #1056

Merged
merged 7 commits into from
Nov 3, 2021
Merged

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Nov 2, 2021

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #1055

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #1056 (7f736f0) into master (cf8b24d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1056   +/-   ##
=======================================
  Coverage   64.35%   64.35%           
=======================================
  Files         171      171           
  Lines        9472     9472           
=======================================
  Hits         6096     6096           
  Misses       2707     2707           
  Partials      669      669           
Impacted Files Coverage Δ
pkg/ddc/jindo/worker.go 77.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf8b24d...7f736f0. Read the comment docs.

Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
@cheyang cheyang requested a review from frankleaf November 3, 2021 06:56
Copy link
Member

@frankleaf frankleaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve, and reasonable to these changes

@cheyang cheyang merged commit c0754f7 into fluid-cloudnative:master Nov 3, 2021
@cheyang cheyang deleted the fix_issue_for_jindo branch November 8, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix rbac issue for jindo
2 participants