Add JuiceFSRuntime engine to fluid backend #1047

zwwhdls · 2021-10-21T07:10:31Z

Ⅰ. Describe what this PR does

Add support for JuiceFS engine to fluid backend.
Proposal can be found in https://docs.google.com/document/d/1f7GVFqNTFktuY1r4DcE-d6mEcTNVrGoMdFlvp3Fg5B4/edit#heading=h.rs8ahthpcict

JuiceFS is a high-performance POSIX file system released under GNU Affero General Public License v3.0. Introduction and open source address can be found in https://github.com/juicedata/juicefs

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Test cases are in /pkg/ddc/juicefs/****_test.go

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov · 2021-11-03T02:20:20Z

Codecov Report

Merging #1047 (338c7d9) into master (b97203d) will increase coverage by 0.54%.
The diff coverage is 68.55%.

@@            Coverage Diff             @@
##           master    #1047      +/-   ##
==========================================
+ Coverage   65.21%   65.75%   +0.54%     
==========================================
  Files         181      207      +26     
  Lines        9765    11292    +1527     
==========================================
+ Hits         6368     7425    +1057     
- Misses       2723     3050     +327     
- Partials      674      817     +143

Impacted Files	Coverage Δ
pkg/ddc/juicefs/metadata.go	`51.28% <51.28%> (ø)`
pkg/ddc/juicefs/shutdown.go	`51.72% <51.72%> (ø)`
pkg/ddc/juicefs/replicas.go	`52.00% <52.00%> (ø)`
pkg/ddc/juicefs/create_volume.go	`53.84% <53.84%> (ø)`
pkg/ddc/base/runtime.go	`71.42% <55.55%> (+0.48%)`	⬆️
pkg/ddc/juicefs/health_check.go	`56.25% <56.25%> (ø)`
pkg/ddc/juicefs/ufs_internal.go	`60.00% <60.00%> (ø)`
pkg/ddc/juicefs/worker.go	`61.97% <61.97%> (ø)`
pkg/ddc/juicefs/master_internal.go	`63.63% <63.63%> (ø)`
pkg/ddc/juicefs/cache.go	`65.11% <65.11%> (ø)`
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b97203d...338c7d9. Read the comment docs.

cheyang · 2021-11-03T02:32:15Z

@zwwhdls Could you please enhance the test coverage. Thanks!

api/v1alpha1/juicefsruntime_types.go

pkg/ddc/juicefs/create_volume.go

pkg/ddc/juicefs/node.go

pkg/ddc/juicefs/report.go

* Add juicefs runtime Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me>

Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me>

* add juicefs_runtime doc & fix bug * add en doc Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me>

Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me>

* Update docker image, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Prefer fuse node affinity, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Prefer fuse node affinity, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Prefer fuse node affinity, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Update docker image, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Update docker image, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Update docker image, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * update config Signed-off-by: cheyang <cheyang@163.com> * Sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> Signed-off-by: zwwhdls <zww@hdls.me>

Signed-off-by: LDawns <lsm@smail.nju.edu.cn> Signed-off-by: zwwhdls <zww@hdls.me>

node-driver-registrar will mount kubelet-dir on {{ .Values.csi.kubelet.rootDir }} without 'HostToContainer' or 'Bidirectional'. If another pod mount a temporary device on their volume directory like '${kubelet-dir}/lib/kubelet/pods/xxx/volumes/' which create before node-driver-registrar and delete after node-driver-registrar is created will cause device deconstruction to fail. Signed-off-by: tuji.yyf <tuji.yyf@alibaba-inc.com> Signed-off-by: zwwhdls <zww@hdls.me>

Signed-off-by: littletiger123 <mg20330006@smail.nju.edu.cn> Signed-off-by: zwwhdls <zww@hdls.me>

…ve#1046) * implement master and fuse resource option Signed-off-by: frankleaf <frank.wt@alibaba-inc.com> * fix ut Signed-off-by: frankleaf <frank.wt@alibaba-inc.com> Signed-off-by: zwwhdls <zww@hdls.me>

* add test case of cert Signed-off-by: yangyuliufeng <qlw705706@gmail.com> * prepare the test environment Signed-off-by: yangyuliufeng <qlw705706@gmail.com> Signed-off-by: zwwhdls <zww@hdls.me>

Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me>

* implement SyncScheduleInfoToCacheNodes * fix golangci-lint Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me>

Signed-off-by: zwwhdls <zww@hdls.me>

* add test * update chart Signed-off-by: zwwhdls <zww@hdls.me>

* add jucefsruntime ut * fix test * update juicefsruntime test Signed-off-by: zwwhdls <zww@hdls.me>

Signed-off-by: zwwhdls <zww@hdls.me>

* change JuiceFSRuntimeStatus to RuntimeStatus Signed-off-by: ldd91 <lvdongdong30@gmail.com> * sync metadata after fuse pod up Signed-off-by: ldd91 <lvdongdong30@gmail.com> * sync metadata after fuse pod up Signed-off-by: ldd91 <lvdongdong30@gmail.com>

--signoff Signed-off-by: zwwhdls <zww@hdls.me>

Signed-off-by: zwwhdls <zww@hdls.me>

api/v1alpha1/juicefsruntime_types.go

Signed-off-by: zwwhdls <zww@hdls.me>

allenhaozi · 2021-11-20T02:59:29Z

good job !
If the comment has been resolved, Take the trouble to reply or click Resolve, thank u

Signed-off-by: zwwhdls <zww@hdls.me>

pkg/ddc/juicefs/cache.go

pkg/ddc/juicefs/dataset.go

pkg/ddc/juicefs/master_internal.go

pkg/ddc/juicefs/master.go

allenhaozi · 2021-11-20T07:47:54Z

pkg/ddc/juicefs/metadata.go

+			}
+			return
+		})
+		if err != nil {


This error does not return, is normal business logic?

Yes, it's update status with "Calculating". Even if it failed here, metadataSync will still go on.

pkg/ddc/juicefs/transform_fuse.go

Signed-off-by: zwwhdls <zww@hdls.me>

yangyuliufeng

according to our previous discussion, the main file should be cut off

cmd/juicefs/main.go

yangyuliufeng · 2021-11-21T04:16:15Z

pkg/ddc/juicefs/dataset.go

+)
+
+// UpdateDatasetStatus updates the status of the dataset
+func (j *JuiceFSEngine) UpdateDatasetStatus(phase datav1alpha1.DatasetPhase) (err error) {


I think UpdateDatasetStatus can be an common logic in the future @cheyang

yangyuliufeng · 2021-11-21T04:16:27Z

pkg/ddc/juicefs/dataset.go

+)
+
+// UpdateDatasetStatus updates the status of the dataset
+func (j *JuiceFSEngine) UpdateDatasetStatus(phase datav1alpha1.DatasetPhase) (err error) {


I think UpdateDatasetStatus can be an common logic in the future @cheyang

pkg/ddc/juicefs/const.go

Signed-off-by: zwwhdls <zww@hdls.me>

* Add juicefs runtime (fluid-cloudnative#11) * Add juicefs runtime Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me> * format --no-update when bucket is none & fix typo & fix test (fluid-cloudnative#12) Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me> * Add doc (fluid-cloudnative#13) * add juicefs_runtime doc & fix bug * add en doc Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me> * update juicefs_runtime.md (fluid-cloudnative#14) Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me> * Add node label after scheduling dataset (fluid-cloudnative#1040) * Update docker image, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Prefer fuse node affinity, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Prefer fuse node affinity, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Prefer fuse node affinity, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Update docker image, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Update docker image, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Update docker image, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * update config Signed-off-by: cheyang <cheyang@163.com> * Sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> * Test for sync up node labels, To #37253115 Signed-off-by: cheyang <cheyang@163.com> Signed-off-by: zwwhdls <zww@hdls.me> * add ut for healthcheck. (fluid-cloudnative#1051) Signed-off-by: LDawns <lsm@smail.nju.edu.cn> Signed-off-by: zwwhdls <zww@hdls.me> * Add mount propagation in node-driver-registrar (fluid-cloudnative#1049) node-driver-registrar will mount kubelet-dir on {{ .Values.csi.kubelet.rootDir }} without 'HostToContainer' or 'Bidirectional'. If another pod mount a temporary device on their volume directory like '${kubelet-dir}/lib/kubelet/pods/xxx/volumes/' which create before node-driver-registrar and delete after node-driver-registrar is created will cause device deconstruction to fail. Signed-off-by: tuji.yyf <tuji.yyf@alibaba-inc.com> Signed-off-by: zwwhdls <zww@hdls.me> * add ut for template_engine.go and metadata.go (fluid-cloudnative#1039) Signed-off-by: littletiger123 <mg20330006@smail.nju.edu.cn> Signed-off-by: zwwhdls <zww@hdls.me> * add master and fuse resource option for jindoruntime (fluid-cloudnative#1046) * implement master and fuse resource option Signed-off-by: frankleaf <frank.wt@alibaba-inc.com> * fix ut Signed-off-by: frankleaf <frank.wt@alibaba-inc.com> Signed-off-by: zwwhdls <zww@hdls.me> * add test case of cert builder (fluid-cloudnative#1042) * add test case of cert Signed-off-by: yangyuliufeng <qlw705706@gmail.com> * prepare the test environment Signed-off-by: yangyuliufeng <qlw705706@gmail.com> Signed-off-by: zwwhdls <zww@hdls.me> * implement SyncScheduleInfoToCacheNodes (fluid-cloudnative#15) Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me> * Fix ci (fluid-cloudnative#16) * implement SyncScheduleInfoToCacheNodes * fix golangci-lint Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me> * fix env/port format & adjust import format (fluid-cloudnative#17) Signed-off-by: zwwhdls <zww@hdls.me> * Add test (fluid-cloudnative#18) * add test * update chart Signed-off-by: zwwhdls <zww@hdls.me> * update juicefsruntime unit test (fluid-cloudnative#19) * add jucefsruntime ut * fix test * update juicefsruntime test Signed-off-by: zwwhdls <zww@hdls.me> * fix confluct Signed-off-by: zwwhdls <zww@hdls.me> * add some test (fluid-cloudnative#20) Signed-off-by: zwwhdls <zww@hdls.me> * Fix cache dir (fluid-cloudnative#21) * fix cache dir Signed-off-by: zwwhdls <zww@hdls.me> * update mountpoint & parse option Signed-off-by: zwwhdls <zww@hdls.me> * fix test Signed-off-by: zwwhdls <zww@hdls.me> * fix nodeSelector in fuse Signed-off-by: zwwhdls <zww@hdls.me> * update doc Signed-off-by: zwwhdls <zww@hdls.me> * fix test (fluid-cloudnative#22) Signed-off-by: zwwhdls <zww@hdls.me> * change JuiceFSRuntimeStatus to RuntimeStatus (fluid-cloudnative#23) * change JuiceFSRuntimeStatus to RuntimeStatus Signed-off-by: ldd91 <lvdongdong30@gmail.com> * sync metadata after fuse pod up Signed-off-by: ldd91 <lvdongdong30@gmail.com> * sync metadata after fuse pod up Signed-off-by: ldd91 <lvdongdong30@gmail.com> * update metaurl in encryptOption (fluid-cloudnative#24) --signoff Signed-off-by: zwwhdls <zww@hdls.me> * fix golangci-lint Signed-off-by: zwwhdls <zww@hdls.me> * fix typo Signed-off-by: zwwhdls <zww@hdls.me> * add test in util Signed-off-by: zwwhdls <zww@hdls.me> * add tests & fix Signed-off-by: zwwhdls <zww@hdls.me> * add tests Signed-off-by: zwwhdls <zww@hdls.me> * add tests Signed-off-by: zwwhdls <zww@hdls.me> * disassemble cmd/main.go into several small files. Signed-off-by: zwwhdls <zww@hdls.me> Co-authored-by: ldd91 <lvdongdong30@gmail.com> Co-authored-by: cheyang <cheyang@163.com> Co-authored-by: LDawn <38764512+LDawns@users.noreply.github.com> Co-authored-by: Yifan Yuan <tuji.yyf@alibaba-inc.com> Co-authored-by: littletiger123 <32997459+littletiger123@users.noreply.github.com> Co-authored-by: frankleaf <62129564+frankleaf@users.noreply.github.com> Co-authored-by: yangyuliufeng <30432274+yangyuliufeng@users.noreply.github.com> Signed-off-by: Dice21 <37772976+Dice21@users.noreply.github.com>

zwwhdls force-pushed the master branch from 00969ea to 9493ca4 Compare October 21, 2021 07:15

cheyang requested review from yangyuliufeng and TrafalgarZZZ November 2, 2021 03:45

zwwhdls force-pushed the master branch 5 times, most recently from e5d5ad3 to 91dadfb Compare November 2, 2021 09:07

cheyang reviewed Nov 3, 2021

View reviewed changes

api/v1alpha1/juicefsruntime_types.go Show resolved Hide resolved

allenhaozi reviewed Nov 4, 2021

View reviewed changes

zwwhdls and others added 15 commits November 8, 2021 11:13

Add juicefs runtime (#11)

b3972e6

* Add juicefs runtime Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me>

format --no-update when bucket is none & fix typo & fix test (#12)

b694a2d

Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me>

Add doc (#13)

1a60141

* add juicefs_runtime doc & fix bug * add en doc Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me>

update juicefs_runtime.md (#14)

aff6d20

Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me>

add ut for healthcheck. (fluid-cloudnative#1051)

00d5875

Signed-off-by: LDawns <lsm@smail.nju.edu.cn> Signed-off-by: zwwhdls <zww@hdls.me>

add ut for template_engine.go and metadata.go (fluid-cloudnative#1039)

ef0946d

Signed-off-by: littletiger123 <mg20330006@smail.nju.edu.cn> Signed-off-by: zwwhdls <zww@hdls.me>

add master and fuse resource option for jindoruntime (fluid-cloudnati…

337608e

…ve#1046) * implement master and fuse resource option Signed-off-by: frankleaf <frank.wt@alibaba-inc.com> * fix ut Signed-off-by: frankleaf <frank.wt@alibaba-inc.com> Signed-off-by: zwwhdls <zww@hdls.me>

add test case of cert builder (fluid-cloudnative#1042)

7dfebe1

* add test case of cert Signed-off-by: yangyuliufeng <qlw705706@gmail.com> * prepare the test environment Signed-off-by: yangyuliufeng <qlw705706@gmail.com> Signed-off-by: zwwhdls <zww@hdls.me>

implement SyncScheduleInfoToCacheNodes (#15)

e3fbda4

Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me>

Fix ci (#16)

0df4deb

* implement SyncScheduleInfoToCacheNodes * fix golangci-lint Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io> Signed-off-by: zwwhdls <zww@hdls.me>

fix env/port format & adjust import format (#17)

064092d

Signed-off-by: zwwhdls <zww@hdls.me>

Add test (#18)

a7a7985

* add test * update chart Signed-off-by: zwwhdls <zww@hdls.me>

update juicefsruntime unit test (#19)

a976a61

* add jucefsruntime ut * fix test * update juicefsruntime test Signed-off-by: zwwhdls <zww@hdls.me>

zwwhdls force-pushed the master branch from 1ad2923 to a976a61 Compare November 8, 2021 03:17

zwwhdls added 2 commits November 8, 2021 11:25

fix confluct

bc8476a

Signed-off-by: zwwhdls <zww@hdls.me>

fix confluct

fbe72af

Signed-off-by: zwwhdls <zww@hdls.me>

zwwhdls force-pushed the master branch from a80b0a4 to 9f0424a Compare November 17, 2021 08:01

fix test (#22)

7aec5b8

Signed-off-by: zwwhdls <zww@hdls.me>

zwwhdls force-pushed the master branch from d13f77d to 7aec5b8 Compare November 17, 2021 08:41

ldd91 and others added 2 commits November 19, 2021 10:40

update metaurl in encryptOption (#24)

13b14bd

--signoff Signed-off-by: zwwhdls <zww@hdls.me>

zwwhdls force-pushed the master branch from 6ae9345 to 13b14bd Compare November 19, 2021 05:35

fix golangci-lint

a75ac30

Signed-off-by: zwwhdls <zww@hdls.me>

cheyang requested review from allenhaozi, TrafalgarZZZ and cheyang November 19, 2021 14:44

cheyang requested changes Nov 20, 2021

View reviewed changes

api/v1alpha1/juicefsruntime_types.go Outdated Show resolved Hide resolved

fix typo

419f7c2

Signed-off-by: zwwhdls <zww@hdls.me>

zwwhdls force-pushed the master branch from b06d5ff to 419f7c2 Compare November 20, 2021 01:27

Merge branch 'fluid-cloudnative:master' into master

7185402

add test in util

ca244e5

Signed-off-by: zwwhdls <zww@hdls.me>

allenhaozi reviewed Nov 20, 2021

View reviewed changes

zwwhdls added 3 commits November 21, 2021 00:10

add tests & fix

da4c57c

Signed-off-by: zwwhdls <zww@hdls.me>

add tests

8b2f195

Signed-off-by: zwwhdls <zww@hdls.me>

add tests

cf47f05

Signed-off-by: zwwhdls <zww@hdls.me>

yangyuliufeng requested changes Nov 21, 2021

View reviewed changes

disassemble cmd/main.go into several small files.

338c7d9

Signed-off-by: zwwhdls <zww@hdls.me>

cheyang approved these changes Nov 22, 2021

View reviewed changes

cheyang requested a review from allenhaozi November 22, 2021 03:38

cheyang merged commit c3d10e3 into fluid-cloudnative:master Nov 22, 2021

RongGu mentioned this pull request Jun 30, 2022

[Community] Nominating Weiwei Zhu(GithubID: zwwhdls) for Fluid committer fluid-cloudnative/community#44

Closed

RongGu mentioned this pull request Feb 14, 2023

[Community] Nominating Weiwei Zhu(GithubID: zwwhdls) for Fluid maintainer fluid-cloudnative/community#45

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add JuiceFSRuntime engine to fluid backend #1047

Add JuiceFSRuntime engine to fluid backend #1047

zwwhdls commented Oct 21, 2021 •

edited

Loading

codecov bot commented Nov 3, 2021 •

edited

Loading

cheyang commented Nov 3, 2021

allenhaozi commented Nov 20, 2021

allenhaozi Nov 20, 2021

zwwhdls Nov 20, 2021

yangyuliufeng left a comment

yangyuliufeng Nov 21, 2021

yangyuliufeng Nov 21, 2021

cheyang Nov 21, 2021

Add JuiceFSRuntime engine to fluid backend #1047

Add JuiceFSRuntime engine to fluid backend #1047

Conversation

zwwhdls commented Oct 21, 2021 • edited Loading

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov bot commented Nov 3, 2021 • edited Loading

Codecov Report

cheyang commented Nov 3, 2021

allenhaozi commented Nov 20, 2021

allenhaozi Nov 20, 2021

Choose a reason for hiding this comment

zwwhdls Nov 20, 2021

Choose a reason for hiding this comment

yangyuliufeng left a comment

Choose a reason for hiding this comment

yangyuliufeng Nov 21, 2021

Choose a reason for hiding this comment

yangyuliufeng Nov 21, 2021

Choose a reason for hiding this comment

cheyang Nov 21, 2021

Choose a reason for hiding this comment

zwwhdls commented Oct 21, 2021 •

edited

Loading

codecov bot commented Nov 3, 2021 •

edited

Loading