Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work with Fluent Assertions 8. #76

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

dennisdoomen
Copy link
Member

No description provided.

@dennisdoomen dennisdoomen requested a review from jnyrup January 16, 2025 09:12
build.sh Outdated
@@ -9,18 +9,15 @@ SCRIPT_DIR=$(cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd)
# CONFIGURATION
###########################################################################

BUILD_PROJECT_FILE="$SCRIPT_DIR/Build/_build.csproj"
TEMP_DIRECTORY="$SCRIPT_DIR/.nuke/temp"
BUILD_PROJECT_FILE="$SCRIPT_DIR/build/_build.csproj"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BUILD_PROJECT_FILE="$SCRIPT_DIR/build/_build.csproj"
BUILD_PROJECT_FILE="$SCRIPT_DIR/Build/_build.csproj"

@@ -10,7 +10,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Nuke.Common" Version="8.1.4" />
<PackageReference Include="Nuke.Common" Version="9.0.3" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be 9.0.4

@coveralls
Copy link

coveralls commented Jan 16, 2025

Pull Request Test Coverage Report for Build 12815197646

Details

  • 22 of 22 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.956%

Totals Coverage Status
Change from base Build 12435318185: 0.0%
Covered Lines: 311
Relevant Lines: 332

💛 - Coveralls

@dennisdoomen dennisdoomen merged commit 0606d9a into fluentassertions:master Jan 16, 2025
1 check passed
@dennisdoomen dennisdoomen deleted the bump-to-fa8 branch January 16, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants