Update to FluentAssertions 5.10.2 #35
Conversation
This update reveals a mismatch in escaping new line characters. Fixed by not replacing new line characters in JSON documents any more.
|
I loved the speed at which my previous PR got merged and published. |
| @@ -90,9 +90,9 @@ public JTokenAssertions(JToken subject) | |||
|
|
|||
| var message = $"JSON document {difference?.ToString().Escape(true)}.{Environment.NewLine}" + | |||
| $"Actual document{Environment.NewLine}" + | |||
| $"{Format(Subject, true).Escape(true)}{Environment.NewLine}" + | |||
| $"{Format(Subject, true).Replace("{", "{{").Replace("}", "}}")}{Environment.NewLine}" + | |||
There was a problem hiding this comment.
Could you add tests to verify the fixes?
This helps showing what is currently broken and that regressions are not introduced.
There was a problem hiding this comment.
Just upgrading makes existing tests fail: When_objects_are_not_equivalent_it_should_throw
Because it will print \r\n instead of going to the next line.
There was a problem hiding this comment.
Ah... I assume this is due to fluentassertions/fluentassertions#987, which changed between 5.6.0 and 5.7.0?
There was a problem hiding this comment.
I see that FA.json has a copy of the Escape method, which is different since the PR you mentioned. We could also align them, but that will effect other usages (for the good or the bad).
| @@ -12,7 +12,7 @@ | |||
| <AllowUnsafeBlocks>false</AllowUnsafeBlocks> | |||
| </PropertyGroup> | |||
| <ItemGroup> | |||
| <PackageReference Include="FluentAssertions" Version="5.0.0" /> | |||
| <PackageReference Include="FluentAssertions" Version="5.10.2" /> | |||
There was a problem hiding this comment.
I'm fine with the upgrade, but out of curiosity, is upgrading the core package part of the fix?
There was a problem hiding this comment.
We're using the newer version of FluentAssertions in our project, so we see the wrong error messages. Apparently the problem is hidden by FA in the older version.
|
@jnyrup better? |
There was a problem hiding this comment.
For the record:
When upgrading FA from 5.6.0 to 5.7.0 #987 changed the way we escape certain characters in failure messages.
This caused these FA.Json tests to fail:
When_objects_are_not_equivalent_it_should_throw
When_properties_contains_curly_braces_BeEquivalentTo_should_not_fail_with_FormatException
When_properties_differ_BeEquivalentTo_should_fail
When_specifying_a_reason_why_object_should_be_equivalent_it_should_use_that_in_the_error_message
This update reveals a mismatch in escaping new line characters.
Fixed by not replacing new line characters in JSON documents any more.