backport: Fix missing error class and test for out_forward #942
Conversation
| @@ -450,9 +450,17 @@ def initialize | |||
| super | |||
| end | |||
|
|
|||
| def format_stream(tag, es) | |||
| if @time_as_integer | |||
There was a problem hiding this comment.
v0.12 doesn't hae time_as_integer option so this commit should not be backported to v0.12
There was a problem hiding this comment.
I've removed @time_as_integer.
Because v0.12 doesn't hae time_as_integer option
|
@tagomoris Can we merge this? |
| def emit(tag, es, chain) | ||
| @emit_count += 1 | ||
| data = es.to_msgpack_stream | ||
| data = format_stream(tag, es) |
There was a problem hiding this comment.
Extracting routine to format_stream is for @time_as_integer so this diff itself is not needed for this patch?
We want to reduce the change without no reason.
|
Honestly speaking, I'm not sure this patch is needed for v0.12 branch. This change is important to add further fixes on these code/plugins, but Code and merging this itself is ok for me. |
|
|
|
@repeatedly Right. But it's just a bug, and its fix should be separated from test-driver fixes ideally, especially in stable branch. |
|
@tagomoris okay. @okkez Could you create a new PR? |
|
@repeatedly OK. Do we need 2 new PRs?
|
This backports #922