Separate system config object from supervisor #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -585,8 +576,9 @@ def change_privilege | |||
| end | |||
|
|
|||
| def init_engine | |||
| init_opts = {:suppress_interval => @suppress_interval, :suppress_config_dump => @suppress_config_dump, :without_source => @without_source} | |||
| Fluent::Engine.init(init_opts) | |||
| # init_opts = {:suppress_interval => @suppress_interval, :suppress_config_dump => @suppress_config_dump, :without_source => @without_source} | |||
…ration to plugins * v0.14 feature: new Plugin API expects these configuration parameters to system config * plugin storage path * default file/directory permissions * many others
467c6c6 to
bd4b5f2
Compare
| module Fluent | ||
| require 'fluent/configurable' | ||
|
|
||
| module SystemConfigMixin |
There was a problem hiding this comment.
Plugins (or PluginSupport modules to be introduced) which need to refer system configurations.
|
Looks good |
tagomoris
added a commit
that referenced
this pull request
Feb 9, 2016
Separate system config object from supervisor
|
Merged. |
cosmo0920
pushed a commit
to cosmo0920/fluentd
that referenced
this pull request
Feb 16, 2016
Separate system config object from supervisor
repeatedly
added a commit
that referenced
this pull request
Feb 16, 2016
Back port separate system config object from supervisor(#794)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to pass system configuration to plugins