-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RPC to dump in memory config #666
Implement RPC to dump in memory config #666
Conversation
Do we really need two ways to dump? |
I'm not sure for now. I think that dump in-memory config in log is really needed. At least, both ways makes easy to dump in-memory configurations. config.dumpAdvantage
Disadvantage
config.getDumpAdvantage
Disadvantage
|
In my opinion, we can monitor Fluentd configuration from remote point continuously with If all plugins uses |
👍 |
@sonots @tagomoris If you are Okay, please merge this PR. |
👍 |
Can we merge this? |
Implement RPC to dump in memory config
Related to #633.
Add
<endpoint>/api/config.dump
to RPC.e.g)
example conf:
Dump API
$ curl http://127.0.0.1:9000//api/config.dump {"ok":true}
then, got:
via HTTP