Add chunk format check in in_forward #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # TODO format error | ||
| # TODO: raise an exception if broken chunk is generated by recoverable situation | ||
| unless msg.is_a?(Array) | ||
| log.warn "incoming chunk is broken:", source: source, msg: msg |
There was a problem hiding this comment.
msg should be inspect -ed for various values, ex: strings with escape code or others.
There was a problem hiding this comment.
inspect is done in log methods.
Line 279 in 7bd529c
|
Are there another concern? |
|
LGTM |
repeatedly
added a commit
that referenced
this pull request
Jun 12, 2015
Add chunk format check in in_forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for which forwarder agent sends broken chunk to aggregators.