Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter out if #filter method returns nil record #515

Merged
merged 2 commits into from
Dec 16, 2014
Merged

filter out if #filter method returns nil record #515

merged 2 commits into from
Dec 16, 2014

Conversation

sonots
Copy link
Member

@sonots sonots commented Dec 16, 2014

Change the filter plugin API as:

  1. filter method raises NotImplementedError as default
  2. filter_stream now behaves not to emit message if filter method returns nil

@repeatedly
Copy link
Member

Could you rewrite filter_grep with this change?

@sonots
Copy link
Member Author

sonots commented Dec 16, 2014

@repeatedly done

repeatedly added a commit that referenced this pull request Dec 16, 2014
@repeatedly
Merge pull request #515 from fluent/filter_nil
2e44478 
filter out if #filter method returns nil record
@repeatedly repeatedly merged commit 2e44478 into master Dec 16, 2014
@sonots sonots deleted the filter_nil branch December 16, 2014 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonots @repeatedly