fix v1 config to support multiple tag match #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d303f3d to
24d9d22
Compare
| @@ -230,4 +230,35 @@ def event_router | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| sub_test_case EventRouter::Rule do | |||
There was a problem hiding this comment.
EventRouter::Rule tests are placed in test_match.rb.
Could you move these tests?
There was a problem hiding this comment.
Ah, I noticed that enough tests were already there. I just removed.
24d9d22 to
e40f9a6
Compare
|
I gonna merge later if there is no more comment. |
sonots
added a commit
that referenced
this pull request
Nov 21, 2014
fix v1 config to support multiple tag match
|
cherry-picked to v0.10 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #475
I also added tests for EventRouter::Rule to make sure that EventRouter supports multiple tags.