'--suppress-repeated-stacktrace' is true by default

[repeatedly]

We keep this option for backward compatibility.
Maybe, there is no user who wants to disable this option on production.
We will remove related code in the future.

From this patch, fluentd behaviour is:

1. without '--suppress-repeated-stacktrace', suppress logs
2. with '--suppress-repeated-stacktrace', suppress logs
3. with '--suppress-repeated-stacktrace true', suppress logs
4. with ''--suppress-repeated-stacktrace false', no suppress logs

[tagomoris]

For debug of Fluentd itself, we need --express-repeated-stacktrace (default false) option!

[repeatedly]

Error content is still logged in the log.
Isn't it enough?

2014-10-02 18:11:37 +0900 [warn]: emit transaction failed  error_class=ArgumentError error=#<ArgumentError: hoge!>
  2014-10-02 18:11:37 +0900 [warn]: suppressed same stacktrace

[repeatedly]

Patch for supporting non-suppress mode with --suppress-repeated-stacktrace false:

diff --git a/lib/fluent/command/fluentd.rb b/lib/fluent/command/fluentd.rb
index dcd3149..b13568d 100644
--- a/lib/fluent/command/fluentd.rb
+++ b/lib/fluent/command/fluentd.rb
@@ -70,7 +70,8 @@ op.on('--emit-error-log-interval SECONDS', "suppress interval seconds of emit er
   opts[:suppress_interval] = s.to_i
 }

-op.on('--suppress-repeated-stacktrace', "suppress repeated stacktrace", TrueClass) {|b|
+op.on('--suppress-repeated-stacktrace [VALUE]', "suppress repeated stacktrace", TrueClass) {|b|
+  b = true if b.nil?
   opts[:suppress_repeated_stacktrace] = b
 }

[tagomoris]

"Isn't it enough?" Yes. Controllable points are welcome :)

[repeatedly]

@tagomoris added. Please check again.

[tagomoris]

LGTM!

[sonots]

👍 --suppress-repeated-stacktrace false is nice.