-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new parser for parser_syslog #2599
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
68f3ec7
parser_syslog: Implement new parser for syslog rfc3164
repeatedly f8af924
parser_json: Add comparison test for regexp and string parser
repeatedly 302852e
parser_syslog: refactor code
repeatedly 94887d8
parser_syslog: Fix only no whitespace content handling
repeatedly 4154272
parser_syslog: Separate broken syslog tests
repeatedly 6fc5fb4
parser_syslog: Remove squeeze from new parser
repeatedly 2bc4294
parser_syslog: Check empty priority case in new parser
repeatedly 60c838f
parser_syslog: Apply review for better variable name
repeatedly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
parser_syslog: Separate broken syslog tests
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
- Loading branch information
commit 41542722d8971f6417255b62cf1d479e90e2bf71
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what the result of parsing it? I think
assert_equal
should be used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actual generated record is not important for this case.
This test shows parser can't parse non-standard HEADER/MSG syslog message correctly, so
assert_not_equal
seems no problem for me.