-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error if timezone with name is used in parser #2421
Conversation
Signed-off-by: Jonas Rutishauser <jonas.rutishauser@alumni.ethz.ch>
Hmm... Could you show the actual example? |
Every zone name has this problem (see https://makandracards.com/makandra/67330-why-you-can-t-use-timezone-codes-like-pst-or-bst-for-time-objects).
|
Thanks. I will check it. |
Your patch has performance penalty and it is not good for existing users.
|
Signed-off-by: Jonas Rutishauser <jonas.rutishauser@alumni.ethz.ch>
Signed-off-by: Jonas Rutishauser <jonas.rutishauser@alumni.ethz.ch>
@ganmacs Could you also check this patch? I want to release v1.5.1 with this patch. |
Signed-off-by: Jonas Rutishauser <jonas.rutishauser@alumni.ethz.ch>
Thanks! |
What this PR does / why we need it:
Fixes a
TypeError: nil can't be coerced into Integer
when a timezone name is used in a parser configuration.