Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parser_syslog regexp for RFC5424 #2141

Merged
merged 4 commits into from
Oct 2, 2018

Conversation

okkez
Copy link
Contributor

@okkez okkez commented Sep 26, 2018

Fix issues reported in #2068 partialy.

  1. not yet for now (I could not find the example about this)
  2. fixed
  3. fixed

Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
In previous version, pid field is too greedy.

See also https://tools.ietf.org/html/rfc5424#section-6 and fluent#2068

Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@repeatedly repeatedly merged commit f4a6f09 into fluent:master Oct 2, 2018
@repeatedly
Copy link
Member

Thanks!

@okkez okkez deleted the improve-parser-syslog branch October 3, 2018 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants