Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

out_http: json_array documentation #184

Merged
merged 3 commits into from
Jun 9, 2020
Merged

out_http: json_array documentation #184

merged 3 commits into from
Jun 9, 2020

Conversation

cosmo0920
Copy link
Contributor

cosmo0920 added 2 commits June 9, 2020 15:17
@cosmo0920
out_http: Add json_array parameter description
b14010a 
Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
@cosmo0920
out_http: Add trouble shooting section
4e6c7de 
Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
@cosmo0920 cosmo0920 requested a review from repeatedly June 9, 2020 06:57
@cosmo0920
Copy link
Contributor Author

b14010a should be needed but I'm not sure 4e6c7de is needed for users.
(We recommend to use inter-Fluentd communicating with in/out forward.)

repeatedly
repeatedly reviewed Jun 9, 2020
View reviewed changes
plugins/output/http.md Outdated
</source>
```

But, we recomment to use in/out [`forward`](forward.md) plugin to communicate with two Fluentds due to at-most-once and at-least-once semantics for rigidty.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type: recommend

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. 😖

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in e2d21f1.

@cosmo0920
out_http: Fix a typo
e2d21f1 
Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
@repeatedly repeatedly merged commit 191f733 into fluent:1.0 Jun 9, 2020
@repeatedly
Copy link
Member

Thanks! Awesome addition :)

@cosmo0920 cosmo0920 deleted the 1.0-out_http-json_array branch June 9, 2020 08:35
@cosmo0920 cosmo0920 mentioned this pull request Jun 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@repeatedly repeatedly repeatedly left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosmo0920 @repeatedly