Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add srv sd document #160

Merged
merged 3 commits into from
Mar 19, 2020
Merged

Add srv sd document #160

merged 3 commits into from
Mar 19, 2020

Conversation

ganmacs
Copy link
Member

@ganmacs ganmacs commented Mar 17, 2020

Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
@ganmacs ganmacs requested review from repeatedly and cosmo0920 March 17, 2020 05:29

| type | default | version |
|:-------|:------------------------|:--------|
| integer | 60 | 1.10.0 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bool.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with some nitpicks.

plugins/service_discovery/srv.md Outdated Show resolved Hide resolved
plugins/service_discovery/srv.md Outdated Show resolved Hide resolved
plugins/service_discovery/srv.md Outdated Show resolved Hide resolved
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
@ganmacs ganmacs merged commit c750731 into fluent:1.0 Mar 19, 2020
@ganmacs ganmacs deleted the add-srv branch March 19, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants