Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to turn off fluent-bit/fluentd controllers when it is not used #612

Closed
Kristian-ZH opened this issue Mar 10, 2023 · 2 comments · Fixed by #621
Closed

Make it possible to turn off fluent-bit/fluentd controllers when it is not used #612

Kristian-ZH opened this issue Mar 10, 2023 · 2 comments · Fixed by #621
Assignees
Labels
good first issue Good for newcomers

Comments

@Kristian-ZH
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently, both controllers (fluentd and fluent-bit) work together and there is no option to disable one of them even when we do not want to use it. This adds the requirement to install all of the CRDs and to create an RBAC with all of the roles there.

Describe the solution you'd like

The installation of the fluent operator should have the option to disable one of the controllers.

Additional context

No response

@wenchajun
Copy link
Member

Yes, we have multiple controllers, which I think is necessary.

Kristian-ZH pushed a commit to Kristian-ZH/gardener that referenced this issue Mar 15, 2023
Currently, fluent operator requires all the CRDs, otherwise it will crash. Ref fluent/fluent-operator#612
@benjaminhuo benjaminhuo added the good first issue Good for newcomers label Mar 16, 2023
@benjaminhuo
Copy link
Member

@Kristian-ZH It'll be great if you can help to make these changes with a PR!

Kristian-ZH pushed a commit to Kristian-ZH/gardener that referenced this issue Mar 16, 2023
Currently, fluent operator requires all the CRDs, otherwise it will crash. Ref fluent/fluent-operator#612
@Kristian-ZH Kristian-ZH changed the title Make it possible to turn off fluent-bit/fluentd controller when it is used Make it possible to turn off fluent-bit/fluentd controllers when it is not used Mar 17, 2023
Kristian-ZH pushed a commit to Kristian-ZH/gardener that referenced this issue Mar 23, 2023
Currently, fluent operator requires all the CRDs, otherwise it will crash. Ref fluent/fluent-operator#612
Kristian-ZH pushed a commit to Kristian-ZH/gardener that referenced this issue Mar 23, 2023
Currently, fluent operator requires all the CRDs, otherwise it will crash. Ref fluent/fluent-operator#612
Kristian-ZH pushed a commit to Kristian-ZH/gardener that referenced this issue Mar 28, 2023
Currently, fluent operator requires all the CRDs, otherwise it will crash. Ref fluent/fluent-operator#612
Kristian-ZH pushed a commit to Kristian-ZH/gardener that referenced this issue Mar 28, 2023
Currently, fluent operator requires all the CRDs, otherwise it will crash. Ref fluent/fluent-operator#612
Kristian-ZH pushed a commit to Kristian-ZH/gardener that referenced this issue Apr 27, 2023
Currently, fluent operator requires all the CRDs, otherwise it will crash. Ref fluent/fluent-operator#612
Kristian-ZH pushed a commit to Kristian-ZH/gardener that referenced this issue Apr 27, 2023
Currently, fluent operator requires all the CRDs, otherwise it will crash. Ref fluent/fluent-operator#612
Kristian-ZH pushed a commit to Kristian-ZH/gardener that referenced this issue May 2, 2023
Currently, fluent operator requires all the CRDs, otherwise it will crash. Ref fluent/fluent-operator#612
Kristian-ZH pushed a commit to Kristian-ZH/gardener that referenced this issue May 9, 2023
Currently, fluent operator requires all the CRDs, otherwise it will crash. Ref fluent/fluent-operator#612
gardener-prow bot pushed a commit to gardener/gardener that referenced this issue May 9, 2023
* Move the existing fluent-operator under the logging component

* Install fluentd CRDs

Currently, fluent operator requires all the CRDs, otherwise it will crash. Ref fluent/fluent-operator#612

* Add aliases for the operator's packages

* Add the fluent-operator component

* Adapt seed reconciler to deploy the fluent-operator

* Delete old fluent-bit resources

* Drop the old fluent-bit chart

* Add healthcheck for the fluent-operator managed resources

* No longer use logging fields from the Gardenlet component config

Now custom resources can be directly deployed to achieve such effect

* Add fluent-operator custom resources for the components of the extensions

* Add fluent-operator custom resources for the cluster-autoscaler component

* Add fluent-operator custom resources for the coredns component

* Add fluent-operator custom resources for the dependency-watchdog component

* Add fluent-operator custom resources for the etcd component

* Add fluent-operator custom resources for the hvpa component

* Add fluent-operator custom resources for the kube-apiserver component

* Add fluent-operator custom resources for the kube-controller-manager component

* Add fluent-operator custom resources for the kube-proxy component

* Add fluent-operator custom resources for the kubernetes-dashboard component

* Add fluent-operator custom resources for the kube-scheduler component

* Add fluent-operator custom resources for the kube-state-metrics component

* Add fluent-operator custom resources for the logging components

* Add fluent-operator custom resources for the monitoring components

* Add fluent-operator custom resources for the metrics-server component

* Add fluent-operator custom resources for the nginx-ingress-shoot component

* Add fluent-operator custom resources for the node-problem-detector component

* Add fluent-operator custom resources for the resource-manager component

* Add fluent-operator custom resources for the vpa component

* Add fluent-operator custom resources for the vpn-seed-server component

* Add fluent-operator custom resources for the vpn-shoot component

* Adapt docs to the fluent-operator contract

* Add fluent-operator custom resources for the machine-controller-manager component

* Add needed network policies

* Adapt components after rebase

* Address Ismail's comments

* Wait for fluent-bit service to be created before pathing it

* Run make generate

* Fix unit tests after the rebase

* Replace the the images with the copied ones

* Address Ismail's new comments

* Address Rafael's comments

* Upgrade Fluent Operator to version v.2.2.0

* Address the rest of Rafael's comments

* Run make generate

* Run make-revendor

* Address Rafael's new comments

* Address Ismail's comments

* Add fluent-operator-custom-resources as depencendy of the fluent-operator in the reconcile flow

* Move the import restrictions to more appropriate places

* Restrict operator's roles

---------

Co-authored-by: Kristian-ZH <k.zhelyazkov@sap.com>
andrerun pushed a commit to andrerun/gardener that referenced this issue Jul 6, 2023
* Move the existing fluent-operator under the logging component

* Install fluentd CRDs

Currently, fluent operator requires all the CRDs, otherwise it will crash. Ref fluent/fluent-operator#612

* Add aliases for the operator's packages

* Add the fluent-operator component

* Adapt seed reconciler to deploy the fluent-operator

* Delete old fluent-bit resources

* Drop the old fluent-bit chart

* Add healthcheck for the fluent-operator managed resources

* No longer use logging fields from the Gardenlet component config

Now custom resources can be directly deployed to achieve such effect

* Add fluent-operator custom resources for the components of the extensions

* Add fluent-operator custom resources for the cluster-autoscaler component

* Add fluent-operator custom resources for the coredns component

* Add fluent-operator custom resources for the dependency-watchdog component

* Add fluent-operator custom resources for the etcd component

* Add fluent-operator custom resources for the hvpa component

* Add fluent-operator custom resources for the kube-apiserver component

* Add fluent-operator custom resources for the kube-controller-manager component

* Add fluent-operator custom resources for the kube-proxy component

* Add fluent-operator custom resources for the kubernetes-dashboard component

* Add fluent-operator custom resources for the kube-scheduler component

* Add fluent-operator custom resources for the kube-state-metrics component

* Add fluent-operator custom resources for the logging components

* Add fluent-operator custom resources for the monitoring components

* Add fluent-operator custom resources for the metrics-server component

* Add fluent-operator custom resources for the nginx-ingress-shoot component

* Add fluent-operator custom resources for the node-problem-detector component

* Add fluent-operator custom resources for the resource-manager component

* Add fluent-operator custom resources for the vpa component

* Add fluent-operator custom resources for the vpn-seed-server component

* Add fluent-operator custom resources for the vpn-shoot component

* Adapt docs to the fluent-operator contract

* Add fluent-operator custom resources for the machine-controller-manager component

* Add needed network policies

* Adapt components after rebase

* Address Ismail's comments

* Wait for fluent-bit service to be created before pathing it

* Run make generate

* Fix unit tests after the rebase

* Replace the the images with the copied ones

* Address Ismail's new comments

* Address Rafael's comments

* Upgrade Fluent Operator to version v.2.2.0

* Address the rest of Rafael's comments

* Run make generate

* Run make-revendor

* Address Rafael's new comments

* Address Ismail's comments

* Add fluent-operator-custom-resources as depencendy of the fluent-operator in the reconcile flow

* Move the import restrictions to more appropriate places

* Restrict operator's roles

---------

Co-authored-by: Kristian-ZH <k.zhelyazkov@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants