-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unescape: Decode \u escaped characters for surrogate pairs correctly #9799
base: master
Are you sure you want to change the base?
Conversation
27a363e
to
b758796
Compare
b758796
to
dfe15aa
Compare
e02c52c
to
b4c023e
Compare
Thanks for following up this quick @cosmo0920! On the other hand, staying strict and rejecting that sequence is likely much better for the user, who won't suddenly find magic replacements in their data. |
b4c023e
to
daee871
Compare
@vit-zikmund 's suggestion is very helpful to get working for handling surrogate pairs. Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io> Co-authored-by: Vit Zikmund <vit.zikmund@themama.ai>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
8febcae
to
991691e
Compare
991691e
to
7930bcd
Compare
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
7930bcd
to
a0acbff
Compare
Now, I'd succeeded to make a green result for OSS-Fuzz task. 💪 |
Currently, we ignore surrogate pairs for \u escape on Unicode representation.
To handle this, we need to process with surrogate pairs manner.
Noe that this representation is also encoded
\uXXXX
representation on creating JSON.On creating msgpack, this unescaping operation is effective.
Closes #9712.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
and send
{"text": "\ud83e\udd17"}
in the same terminal.If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.