Update docs for MAX_FILE_SIZE_PUT_OBJECT. #839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weijian Zhang <weijianz@amazon.com>
PettitWesley
requested changes
Jul 8, 2022
| @@ -26,6 +26,7 @@ See [here](https://github.com/fluent/fluent-bit-docs/tree/43c4fe134611da471e706b | |||
| | json_date_format | Specify the format of the date. Supported formats are _double_, _epoch_, _iso8601_ (eg: _2018-05-30T09:39:52.000681Z_) and _java_sql_timestamp_ (eg: _2018-05-30 09:39:52.000681_) | iso8601 | | |||
| | total_file_size | Specifies the size of files in S3. Maximum size is 50G, minimim is 1M. | 100M | | |||
| | upload_chunk_size | The size of each 'part' for multipart uploads. Max: 50M | 5,242,880 bytes | | |||
| | MAX_FILE_SIZE_PUT_OBJECT | Max file size allowed to publish to S3 MAX: 1GB. | 1,073,741,824 bytes | | |||
There was a problem hiding this comment.
this isn't a new user config option. Its a different max size for total_file_size for the use_put_object case
There was a problem hiding this comment.
so we may dont need the MAX_FILE_SIZE_PUT_OBJECT to be list in the documentation .
There was a problem hiding this comment.
yea just note the max allowed value in the total_file_size row a little farther up, that's what I mean
|
@zwj102030 please rebase and update |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Closing in favor of: https://github.com/PettitWesley/fluent-bit-docs/pull/new/s3-putobject-maxsize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the doc for MAX_FILE_SIZE_PUT_OBJECT.
Related PR
fluent/fluent-bit#5688
Signed-off-by: Weijian Zhang weijianz@amazon.com