Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use markdown table #13

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jan 22, 2021

No description provided.

Copy link
Member

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd already used fluent-plugin-config-format like format on README.
Could you try to add markdown table style dumping functionality in fluent-plugin-config-format?

@kenhys
Copy link
Contributor Author

kenhys commented Feb 2, 2021

I've sent PR fluent-pugin-config-format.
fluent/fluentd#3240

Copy link
Member

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reviewed a PR: fluent/fluentd#3240
Looks good to me. 👍

@cosmo0920 cosmo0920 merged commit 3a19beb into fluent-plugins-nursery:master Feb 4, 2021
@cosmo0920
Copy link
Member

@kenhys Could you add desc method for each parameter? Currently, there is no desc in this plugin.

@kenhys
Copy link
Contributor Author

kenhys commented Feb 4, 2021

Ok, I'll do it.

@kenhys kenhys deleted the fix-format branch February 4, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants