Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update UniformDesc return type in Zig generator #155

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Conversation

opzap
Copy link
Contributor

@opzap opzap commented Nov 16, 2024

A project failed to compile when I added runtime reflection to my shaders because sokol.gfx had no member named GlslShaderUniformDesc

the reflected type now matches the changes made in floooh/sokol@a120657 and floooh/sokol-zig@255e68f

@floooh
Copy link
Owner

floooh commented Nov 16, 2024

Thanks! Oversight on my part (none of the sokol-zig samples use the reflection output, so that slipped through).

Btw, with the new resouce bindings changes, the dynamic reflection info might not be as critical as before because it's now possible to explicitly define bindslot locations, and also to have gaps in the bindslot ranges. E.g. it's now possible to use the same bindings across different shaders, even when those shaders don't use a speciifc binding.

@floooh floooh merged commit 4fa45e2 into floooh:master Nov 16, 2024
3 checks passed
@floooh
Copy link
Owner

floooh commented Nov 16, 2024

Binaries will be updated when this CI pipeline goes green: https://github.com/floooh/sokol-tools/actions/runs/11870326860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants