Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a lot of small issues with the initial PR that merged the code generator for Jai (ie: it doesn't compile), so i though i'd open a PR for the fixed since i've been using a private fork for a while.
The current version in master had invalid syntax so i'm assuming the author used the syntax of Odin (or another) and forgot to replace some of the things.
I compiled the SDF.glsl file from the samples to show the differences in output to save some time.
Most issues were
,
instead of;
and struct padding issues and i also removed the#scope_module
since that's the default.I've a comment to explain why i don't think importing
sokol_gfx
is the right call at the moment, let me know what you think about this.I also have generated the bindings for sokol, if that's something you'd be interested in let me.
Current:
Fixed:
Edit: turns out, it's a huge pain to post text files inside a PR on GitHub and the editor is super laggy now, uh... Sorry for the mess.