OF13 Fix Bucket class watch port and group defaults #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Bucket class watch_port and watch_group fields should default to OFPP_ANY and OFPG_ANY respectively, rather than both defaulting to 0. Zero is an invalid port number and a valid group number. See OpenFlow Switch v1.3.4 section 7.3.4.2 for details.
|
I realise I have gone about this the wrong way and the loxigen project actually needs the fix to set the default values here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bucket class watch_port and watch_group fields should default to
OFPP_ANY and OFPG_ANY respectively, rather than both defaulting to 0.
Zero is an invalid port number and a valid group number.
See OpenFlow Switch v1.3.4 section 7.3.4.2 for details.
See issue #219