Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: top down product creation if no unit are created #109

Open
wants to merge 24 commits into
base: staging
Choose a base branch
from
Open

feat: top down product creation if no unit are created #109

wants to merge 24 commits into from

Conversation

39bytes
Copy link
Contributor

@39bytes 39bytes commented Apr 24, 2024

No description provided.

@39bytes 39bytes requested a review from itsjoeoui as a code owner April 24, 2024 21:42
@linear Linear
Copy link

linear bot commented Apr 24, 2024

CLO-132 Top down Product creation if no Unit are created

@railway-app Railway App
Copy link

railway-app bot commented Apr 24, 2024

This PR was not deployed automatically as @39bytes does not have access to the Railway project.

In order to get automatic PR deploys, please add @39bytes to your team on Railway.

LatentDream
LatentDream reviewed Apr 26, 2024
View reviewed changes
Copy link
Member

@LatentDream LatentDream left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core feature is goooodd, some points double checked to be sure

  • Algo to detect cycle verified
  • Verification server side

apps/web/src/components/unit/edit-part-variation.tsx Outdated Show resolved Hide resolved
apps/server/src/db/part-variation.ts Outdated Show resolved Hide resolved
apps/web/src/components/project/new-project.tsx Outdated Show resolved Hide resolved
apps/web/src/components/unit/swap-unit.tsx Outdated Show resolved Hide resolved
apps/server/src/db/part-variation.ts Outdated Show resolved Hide resolved
apps/server/src/db/part-variation.ts Outdated Show resolved Hide resolved
apps/server/src/db/part-variation.ts Outdated Show resolved Hide resolved
LatentDream
LatentDream approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@LatentDream LatentDream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depth not needed as said on Slack, Approved for me :) Maybe just change the "create" to "update" in the Modal

39bytes and others added 4 commits April 29, 2024 15:37
@39bytes @LatentDream
fix: create -> update
c65484d 
Co-authored-by: Gui <guillaume.thibault.98@proton.me>
@39bytes @LatentDream
fix: relative import -> absolute
5ce12b4 
Co-authored-by: Gui <guillaume.thibault.98@proton.me>
@39bytes @LatentDream
fix: relative import -> absolute
b3f03e0 
Co-authored-by: Gui <guillaume.thibault.98@proton.me>
@39bytes
chore: update error text
a7c3974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsjoeoui itsjoeoui itsjoeoui requested changes

@LatentDream LatentDream LatentDream approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@39bytes @itsjoeoui @LatentDream