Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Add RSA blocks #43

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dstrande
Copy link
Contributor

@dstrande dstrande commented Dec 5, 2023

Copy link

linear bot commented Dec 5, 2023

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 8:35pm

Copy link
Contributor

@39bytes 39bytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main concern is the dll that's loaded in each block, hardcoded path and windows only seems a bit weird to me

Comment on lines +50 to +59
defau = "C:/Tektronix/RSA_API/lib/x64/RSA_API.dll"
moved = "C:/Program Files/Tek/RSA_API/lib/x64/RSA_API.dll"
if path.isfile(defau):
rsa = cdll.LoadLibrary(defau)
elif path.isfile(moved):
rsa = cdll.LoadLibrary(moved)
else:
raise FileNotFoundError(
"Cannot find RSA_API.dll. Download from: https://www.tek.com/en/products/spectrum-analyzers/rsa500"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this dll always located here? Also, this only works on windows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's only available for Windows. The default install location is the second one but I moved mine because I didn't want it on C: directly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants