Skip to content

Add linter workflow and fix reported issues #9

Add linter workflow and fix reported issues

Add linter workflow and fix reported issues #9

Triggered via pull request November 19, 2024 12:46
@floberndflobernd
synchronize #5
linter
Status Failure
Total duration 31s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

9 errors and 10 warnings
ActionLint: .github/workflows/docker_release.yml#L57
[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2086:info:2:43: Double quote to prevent globbing and word splitting [shellcheck] Raw Output: .github/workflows/docker_release.yml:57:9: shellcheck reported issue in this script: SC2086:info:2:43: Double quote to prevent globbing and word splitting [shellcheck]
ActionLint: .github/workflows/docker_release.yml#L160
[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2046:warning:1:33: Quote this to prevent word splitting [shellcheck] Raw Output: .github/workflows/docker_release.yml:160:9: shellcheck reported issue in this script: SC2046:warning:1:33: Quote this to prevent word splitting [shellcheck]
ActionLint: .github/workflows/docker_release.yml#L160
[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2046:warning:2:3: Quote this to prevent word splitting [shellcheck] Raw Output: .github/workflows/docker_release.yml:160:9: shellcheck reported issue in this script: SC2046:warning:2:3: Quote this to prevent word splitting [shellcheck]
ShellCheck: minecraft-ftb/data/docker-entrypoint.sh#L13
[shellcheck] reported by reviewdog 🐶 Argument mixes string and array. Use * or separate argument. Raw Output: ./minecraft-ftb/data/docker-entrypoint.sh:13:41: error: Argument mixes string and array. Use * or separate argument. (ShellCheck.SC2145)
ShellCheck: minecraft-ftb/data/docker-entrypoint.sh#L17
[shellcheck] reported by reviewdog 🐶 Argument mixes string and array. Use * or separate argument. Raw Output: ./minecraft-ftb/data/docker-entrypoint.sh:17:40: error: Argument mixes string and array. Use * or separate argument. (ShellCheck.SC2145)
ShellCheck: minecraft-ftb/data/docker-entrypoint.sh#L135
[shellcheck] reported by reviewdog 🐶 This expression is constant. Did you forget a $ somewhere? Raw Output: ./minecraft-ftb/data/docker-entrypoint.sh:135:12: error: This expression is constant. Did you forget a $ somewhere? (ShellCheck.SC2078)
ShellCheck
reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
ShellCheck
Process completed with exit code 1.
Hadolint
Process completed with exit code 1.
ShellCheck: minecraft-ftb/data/docker-entrypoint.sh#L54
[shellcheck] reported by reviewdog 🐶 Quote this to prevent word splitting. Raw Output: ./minecraft-ftb/data/docker-entrypoint.sh:54:34: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)
ShellCheck: minecraft-ftb/data/docker-entrypoint.sh#L55
[shellcheck] reported by reviewdog 🐶 ansi_green is referenced but not assigned. Raw Output: ./minecraft-ftb/data/docker-entrypoint.sh:55:80: warning: ansi_green is referenced but not assigned. (ShellCheck.SC2154)
ShellCheck: minecraft-ftb/data/docker-entrypoint.sh#L66
[shellcheck] reported by reviewdog 🐶 Declare and assign separately to avoid masking return values. Raw Output: ./minecraft-ftb/data/docker-entrypoint.sh:66:11: warning: Declare and assign separately to avoid masking return values. (ShellCheck.SC2155)
ShellCheck: minecraft-ftb/data/docker-entrypoint.sh#L80
[shellcheck] reported by reviewdog 🐶 Declare and assign separately to avoid masking return values. Raw Output: ./minecraft-ftb/data/docker-entrypoint.sh:80:11: warning: Declare and assign separately to avoid masking return values. (ShellCheck.SC2155)
ShellCheck: minecraft-ftb/data/docker-entrypoint.sh#L129
[shellcheck] reported by reviewdog 🐶 success appears unused. Verify use (or export if used externally). Raw Output: ./minecraft-ftb/data/docker-entrypoint.sh:129:13: warning: success appears unused. Verify use (or export if used externally). (ShellCheck.SC2034)
ShellCheck: minecraft-ftb/data/docker-entrypoint.sh#L141
[shellcheck] reported by reviewdog 🐶 Don't use variables in the printf format string. Use printf '..%s..' "$foo". Raw Output: ./minecraft-ftb/data/docker-entrypoint.sh:141:12: info: Don't use variables in the printf format string. Use printf '..%s..' "$foo". (ShellCheck.SC2059)
ShellCheck: minecraft-ftb/data/docker-entrypoint.sh#L149
[shellcheck] reported by reviewdog 🐶 Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A\"B\"C"? Raw Output: ./minecraft-ftb/data/docker-entrypoint.sh:149:29: warning: Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A\"B\"C"? (ShellCheck.SC2140)
ShellCheck: minecraft-ftb/data/docker-entrypoint.sh#L211
[shellcheck] reported by reviewdog 🐶 Quote this to prevent word splitting. Raw Output: ./minecraft-ftb/data/docker-entrypoint.sh:211:47: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)
ShellCheck: minecraft-ftb/data/docker-entrypoint.sh#L211
[shellcheck] reported by reviewdog 🐶 Use find instead of ls to better handle non-alphanumeric filenames. Raw Output: ./minecraft-ftb/data/docker-entrypoint.sh:211:49: info: Use find instead of ls to better handle non-alphanumeric filenames. (ShellCheck.SC2012)
Hadolint: minecraft-ftb/data/Dockerfile#L14
[hadolint] reported by reviewdog 🐶 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` Raw Output: message:"Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`" location:{path:"minecraft-ftb/data/Dockerfile" range:{start:{line:14 column:1}}} severity:WARNING source:{name:"hadolint" url:"https://github.com/hadolint/hadolint"} code:{value:"DL3008" url:"https://github.com/hadolint/hadolint/wiki/DL3008"}