Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error message for connection exceptions #68

Merged
merged 5 commits into from
Aug 10, 2022

Conversation

Elnadrion
Copy link
Contributor

Hi there!

There is only handling of Guzzle RequestExceptions. When my team and I got another type of exception - package drives us crazy with it's message 😅 I've changed this behavior, and turn this:

image

into this:

image

@Elnadrion
Copy link
Contributor Author

@tPl0ch could you please check this PR?

@Elnadrion
Copy link
Contributor Author

Omg I have this tests failed in master branch 😅

@Elnadrion
Copy link
Contributor Author

Elnadrion commented Aug 9, 2022

@tPl0ch looks like you haven't set a new tag in avro-php lib
Look:
https://github.com/flix-tech/avro-php/blob/4.2.0/lib/avro/schema.php#L392
https://github.com/flix-tech/avro-php/blob/master/lib/avro/schema.php#L392

Latest fix from master branch solves this tests

@Elnadrion Elnadrion force-pushed the fix/connect-exceptions branch from ff9c2ea to d4ccd80 Compare August 9, 2022 15:18
@Elnadrion Elnadrion mentioned this pull request Aug 9, 2022
@tPl0ch
Copy link
Collaborator

tPl0ch commented Aug 10, 2022

@Elnadrion can you merge the latest changes into your branch? You already did 👍

@Elnadrion
Copy link
Contributor Author

Elnadrion commented Aug 10, 2022

I'm watching you subscribed to this repository :)

@Elnadrion
Copy link
Contributor Author

I haven't pulled new CI checks though. 1 sec

@tPl0ch tPl0ch merged commit 1b37e80 into flix-tech:master Aug 10, 2022
@tPl0ch
Copy link
Collaborator

tPl0ch commented Aug 10, 2022

Released as https://github.com/flix-tech/schema-registry-php-client/releases/tag/7.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants