feat(rust): Add traits for generalizing the token strategy #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markphelps
reviewed
Jan 15, 2024
flipt-rust/src/api/mod.rs
Outdated
| @@ -44,6 +37,6 @@ impl FliptClient { | |||
|
|
|||
| impl Default for FliptClient { | |||
| fn default() -> Self { | |||
| Self::new(Config::default()).unwrap() | |||
| Self::new::<ClientTokenAuthentication>(Config::default()).unwrap() | |||
There was a problem hiding this comment.
I think we might want a None authentication strategy and make that the default?
There was a problem hiding this comment.
@markphelps Haha yeah that was what I was thinking. Should have posed that question here. I added it.
markphelps
approved these changes
Jan 15, 2024
This was referenced Jan 15, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the other SDKs we are generalizing the
AuthenticationStrategyas we might support more in the future, and the semantics of how they can get generated can vary from one to the next.This PR adds support for generalizing the
AuthenticationStrategyfor the rust client.Closes: #64.